Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 5742 - centered tooltip after detail changes #5751

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • For a new product, we ask the product type first.
  • Then, we land on the photo page, but meanwhile we save the "this is a product of this type" info on the type-related server, which triggers a background task and a tooltip message.
  • Now, we center the tooltip message (instead of bottomCenter), which doesn't block the view of the bottom buttons anymore.

Screenshot

Screenshot_1730037243

Fixes bug(s)

Impacted file

  • background_task_details.dart: centered instead of bottomCentered

Impacted file:
* `background_task_details.dart`: centered instead of bottomCentered
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.01%. Comparing base (4d9c7fc) to head (386ef98).
Report is 398 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5751      +/-   ##
==========================================
- Coverage     9.54%   7.01%   -2.54%     
==========================================
  Files          325     407      +82     
  Lines        16411   21804    +5393     
==========================================
- Hits          1567    1530      -37     
- Misses       14844   20274    +5430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍 @monsieurtanuki

@g123k
Copy link
Collaborator

g123k commented Oct 27, 2024

@monsieurtanuki Sometimes, this tooltip needs to be centered (e.g.: on the image page).
Have you checked there is no regression for this one?

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki Sometimes, this tooltip needs to be centered (e.g.: on the image page). Have you checked there is no regression for this one?

This centered tooltip is only for "product detail change".
I moved it in order to fix the related issue.
If in other pages centering the tooltip causes bugs, then we'll have to pass an additional parameter to the background task, to say centered or bottomCentered tooltip, which is a feature that hasn't been coded or even evoked yet.
We'll see.

@monsieurtanuki monsieurtanuki merged commit 3260024 into openfoodfacts:develop Oct 27, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon @g123k for your review and comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

the tooltip is blocking clicking next for a few seconds
4 participants